Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19992#discussion_r159083551
--- Diff: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala
---
@@ -2022,12 +1947,7 @@ private[spark] object JsonProtocolSuite extends
Assertions {
| "Port": 300
| },
| "Block ID": "rdd_0_0",
- | "Storage Level": {
--- End diff --
I share sean's concern, I don't think your response is addressing it. You
added one test on L151 makes sure that some event which is *not* predefined
still works. But you don't have a test making sure that the old, verbose
string can still be parsed (or is it somewhere else?)
probably this is indirectly covered by HistoryServerSuite but a more
direrct test would be better
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
