GitHub user gatorsmile opened a pull request:

    https://github.com/apache/spark/pull/20037

    [SPARK-22849] ivy.retrieve pattern should also consider `classifier`

    ## What changes were proposed in this pull request?
    In the previous PR 
https://github.com/apache/spark/pull/5755#discussion_r157848354, we dropped 
`(-[classifier])` from the retrieval pattern. We should add it back; otherwise, 
    > If this pattern for instance doesn't has the [type] or [classifier] 
token, Ivy will download the source/javadoc artifacts to the same file as the 
regular jar.
    
    ## How was this patch tested?
    The existing tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gatorsmile/spark addClassifier

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20037.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20037
    
----
commit 331ba338ce020a927fcfd88b3bd7e536fc8d3b66
Author: gatorsmile <gatorsmile@...>
Date:   2017-12-20T16:59:25Z

    fix

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to