Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20037#discussion_r158089460
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -1271,7 +1271,7 @@ private[spark] object SparkSubmitUtils {
// retrieve all resolved dependencies
ivy.retrieve(rr.getModuleDescriptor.getModuleRevisionId,
packagesDirectory.getAbsolutePath + File.separator +
- "[organization]_[artifact]-[revision].[ext]",
+ "[organization]_[artifact]-[revision](-[classifier]).[ext]",
--- End diff --
In my example,
```
zookeeper-jar: {artifact=zookeeper, ext=jar, module=zookeeper,
classifier=tests, organisation=org.apache.zookeeper, type=test-jar,
revision=3.4.6}
zookeeper-jar: {artifact=zookeeper, ext=jar, module=zookeeper,
organisation=org.apache.zookeeper, type=jar, revision=3.4.6}
```
Both dependencies will have the same name
`org.apache.zookeeper_zookeeper-3.4.6.jar` and cause the collision. After my
PR, they will be different names
`org.apache.zookeeper_zookeeper-3.4.6.jar`
`org.apache.zookeeper_zookeeper-3.4.6-tests.jar`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
