Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19954#discussion_r158167623
  
    --- Diff: 
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/steps/DriverMountSecretsStepSuite.scala
 ---
    @@ -0,0 +1,47 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.k8s.submit.steps
    +
    +import org.apache.spark.{SparkConf, SparkFunSuite}
    +import org.apache.spark.deploy.k8s.MountSecretsBootstrap
    +import org.apache.spark.deploy.k8s.submit.{KubernetesDriverSpec, 
SecretVolumeUtils}
    +
    +class DriverMountSecretsStepSuite extends SparkFunSuite {
    +
    +  private val SECRET_FOO = "foo"
    +  private val SECRET_BAR = "bar"
    +  private val SECRET_MOUNT_PATH = "/etc/secrets/driver"
    +
    +  test("Mounts all given secrets") {
    +    val baseDriverSpec = KubernetesDriverSpec.initialSpec(new 
SparkConf(false))
    +    val secretNamesToMountPaths = Map(
    +      SECRET_FOO -> SECRET_MOUNT_PATH,
    +      SECRET_BAR -> SECRET_MOUNT_PATH)
    +
    +    val mountSecretsBootstrap = new 
MountSecretsBootstrap(secretNamesToMountPaths)
    +    val mountSecretsStep = new 
DriverMountSecretsStep(mountSecretsBootstrap)
    +    val configuredDriverSpec = 
mountSecretsStep.configureDriver(baseDriverSpec)
    +    val driverPodWithSecretsMounted = configuredDriverSpec.driverPod
    +    val driverContainerWithSecretsMounted = 
configuredDriverSpec.driverContainer
    +
    +    Seq(s"$SECRET_FOO-volume", s"$SECRET_BAR-volume").foreach(volumeName =>
    --- End diff --
    
    `.foreach { volumeName =>`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to