Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19954#discussion_r158168037
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/steps/initcontainer/InitContainerConfigOrchestratorSuite.scala
---
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.deploy.k8s.submit.steps.initcontainer
+
+import org.apache.spark.{SparkConf, SparkFunSuite}
+import org.apache.spark.deploy.k8s.Config._
+import org.apache.spark.deploy.k8s.Constants._
+
+class InitContainerConfigOrchestratorSuite extends SparkFunSuite {
+
+ private val DOCKER_IMAGE = "init-container"
+ private val SPARK_JARS = Seq(
+ "hdfs://localhost:9000/app/jars/jar1.jar", "file:///app/jars/jar2.jar")
+ private val SPARK_FILES = Seq(
+ "hdfs://localhost:9000/app/files/file1.txt",
"file:///app/files/file2.txt")
+ private val JARS_DOWNLOAD_PATH = "/var/data/jars"
+ private val FILES_DOWNLOAD_PATH = "/var/data/files"
+ private val DOCKER_IMAGE_PULL_POLICY: String = "IfNotPresent"
+ private val CUSTOM_LABEL_KEY = "customLabel"
+ private val CUSTOM_LABEL_VALUE = "customLabelValue"
+ private val INIT_CONTAINER_CONFIG_MAP_NAME = "spark-init-config-map"
+ private val INIT_CONTAINER_CONFIG_MAP_KEY = "spark-init-config-map-key"
+ private val SECRET_FOO = "foo"
+ private val SECRET_BAR = "bar"
+ private val SECRET_MOUNT_PATH = "/etc/secrets/init-container"
+
+ test ("including basic configuration step") {
+ val sparkConf = new SparkConf(true)
+ .set(INIT_CONTAINER_IMAGE, DOCKER_IMAGE)
+ .set(s"$KUBERNETES_DRIVER_LABEL_PREFIX$CUSTOM_LABEL_KEY",
CUSTOM_LABEL_VALUE)
+
+ val orchestrator = new InitContainerConfigOrchestrator(
+ SPARK_JARS.take(1),
+ SPARK_FILES,
+ JARS_DOWNLOAD_PATH,
+ FILES_DOWNLOAD_PATH,
+ DOCKER_IMAGE_PULL_POLICY,
+ INIT_CONTAINER_CONFIG_MAP_NAME,
+ INIT_CONTAINER_CONFIG_MAP_KEY,
+ sparkConf)
+ val initSteps : Seq[InitContainerConfigurationStep] =
+ orchestrator.getAllConfigurationSteps
+ assert(initSteps.lengthCompare(1) == 0)
+
assert(initSteps.head.isInstanceOf[BasicInitContainerConfigurationStep])
+ }
+
+ test("including step to mount user-specified secrets") {
+ val sparkConf = new SparkConf(false)
+ .set(INIT_CONTAINER_IMAGE, DOCKER_IMAGE)
+ .set(s"$KUBERNETES_DRIVER_SECRETS_PREFIX$SECRET_FOO",
SECRET_MOUNT_PATH)
+ .set(s"$KUBERNETES_DRIVER_SECRETS_PREFIX$SECRET_BAR",
SECRET_MOUNT_PATH)
+
+ val orchestrator = new InitContainerConfigOrchestrator(
+ SPARK_JARS.take(1),
+ SPARK_FILES,
+ JARS_DOWNLOAD_PATH,
+ FILES_DOWNLOAD_PATH,
+ DOCKER_IMAGE_PULL_POLICY,
+ INIT_CONTAINER_CONFIG_MAP_NAME,
+ INIT_CONTAINER_CONFIG_MAP_KEY,
+ sparkConf)
+ val initSteps : Seq[InitContainerConfigurationStep] =
--- End diff --
no space before `:`; in fact the type isn't really needed here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
