Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19591#discussion_r158200059
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -171,10 +90,11 @@ void monitorChild() {
}
synchronized (this) {
- if (disposed) {
+ if (isDisposed()) {
return;
}
+ State currState = getState();
--- End diff --
this was added just because `currState` is no longer accessible, right?
You're not particularly trying to grab the state before the call to
`disconnect()`? Might be clearly to move it after, otherwise on first read it
looks like it is trying to grab the state before its modified by `disconnect()`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
