Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19591#discussion_r158351004
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
    @@ -260,24 +264,30 @@ private long getConnectionTimeout() {
       }
     
       private String createSecret() {
    -    byte[] secret = new byte[128];
    -    RND.nextBytes(secret);
    -
    -    StringBuilder sb = new StringBuilder();
    -    for (byte b : secret) {
    -      int ival = b >= 0 ? b : Byte.MAX_VALUE - b;
    -      if (ival < 0x10) {
    -        sb.append("0");
    +    while (true) {
    --- End diff --
    
    Not really, it's mostly moving the logic that existed before (look for 
`while (server.pending.containsKey(secret))`).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to