Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r158549591
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -120,11 +121,12 @@ abstract class JdbcDialect extends Serializable {
* The SQL query that should be used to truncate a table. Dialects can
override this method to
* return a query that is suitable for a particular database. For
PostgreSQL, for instance,
* a different query is used to prevent "TRUNCATE" affecting other
tables.
- * @param table The name of the table.
+ * @param table The table to truncate
+ * @param cascade (OPTIONAL) Whether or not to cascade the truncation.
Default: false
* @return The SQL query to use for truncating a table
*/
@Since("2.3.0")
- def getTruncateQuery(table: String): String = {
+ def getTruncateQuery(table: String, cascade: Boolean = false): String = {
--- End diff --
Could you remove the default value here?
It could be safe to prevent accidental inheritance of this wrong
implementation.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
