Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19683#discussion_r158716207
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ---
    @@ -115,7 +113,8 @@ case class Generate(
       }
     
       def output: Seq[Attribute] = {
    -    if (join) child.output ++ qualifiedGeneratorOutput else 
qualifiedGeneratorOutput
    +    if (requiredChildOutput.nonEmpty) child.output ++ 
qualifiedGeneratorOutput
    --- End diff --
    
    This should be `child.output ++ requiredChildOutput`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to