Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19683#discussion_r158716496
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -695,7 +695,7 @@ class Analyzer(
               (oldVersion, oldVersion.copy(aggregateExpressions = 
newAliases(aggregateExpressions)))
     
             case oldVersion: Generate
    -            if 
oldVersion.generatedSet.intersect(conflictingAttributes).nonEmpty =>
    +            if 
oldVersion.producedAttributes.intersect(conflictingAttributes).nonEmpty =>
    --- End diff --
    
    Is this correct? `AttributeSet.intersect` is special.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to