Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2696#discussion_r18994206
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/UIData.scala ---
    @@ -65,4 +66,10 @@ private[jobs] object UIData {
           var taskInfo: TaskInfo,
           var taskMetrics: Option[TaskMetrics] = None,
           var errorMessage: Option[String] = None)
    +
    +  case class JobUIData(
    --- End diff --
    
    Pretty minor, but I would move this above `StageUIData` so the organization 
of the code is Job > Stage > Task. Also, this should probably not be a case 
class (`TaskUIData` is a bad example)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to