Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2696#issuecomment-59449668
This looks pretty good to me. As discussed offline, it's worth considering
putting the new logic in SparkContext into a trait and mix it in. This will
mark the first step towards simplifying SparkContext through mixed-in traits. I
don't think we can do something similar for Java, however, so that's a reason
not to do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
