Github user superbobry commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19992#discussion_r159153806
  
    --- Diff: core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala 
---
    @@ -2022,12 +1947,7 @@ private[spark] object JsonProtocolSuite extends 
Assertions {
           |      "Port": 300
           |    },
           |    "Block ID": "rdd_0_0",
    -      |    "Storage Level": {
    --- End diff --
    
    I've added a test ensuring all predefine storage levels can be read from 
the legacy format.
    
    Sidenote: I've also noticed that the legacy format incorrectly handled the 
predefined `StorageLevel.OFF_HEAP` and an fact any other custom storage level 
with `useOffHeap = true`. It looks like a bug to me, wdyt?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to