Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20010#discussion_r159119696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -148,6 +160,61 @@ object TypeCoercion {
case (l, r) => None
}
+ /**
+ * Case 2 type widening over complex types. `widerTypeFunc` is a
function that finds the wider
+ * type over point types. The `widerTypeFunc` specifies behavior over
whether types should be
+ * promoted to StringType.
+ */
+ private def findWiderTypeForTwoComplex(
+ t1: DataType,
+ t2: DataType,
+ widerTypeFunc: (DataType, DataType) => Option[DataType]):
Option[DataType] = {
+ (t1, t2) match {
+ case (_, _) if t1 == t2 => Some(t1)
+ case (NullType, _) => Some(t1)
+ case (_, NullType) => Some(t1)
+
+ case (ArrayType(pointType1, nullable1), ArrayType(pointType2,
nullable2)) =>
+ val dataType = widerTypeFunc.apply(pointType1, pointType2)
+
+ dataType.map(ArrayType(_, nullable1 || nullable2))
+
+ case (MapType(keyType1, valueType1, nullable1), MapType(keyType2,
valueType2, nullable2)) =>
+ val keyType = widerTypeFunc.apply(keyType1, keyType2)
+ val valueType = widerTypeFunc.apply(valueType1, valueType2)
+
+ if (keyType.nonEmpty && valueType.nonEmpty) {
+ Some(MapType(keyType.get, valueType.get, nullable1 || nullable2))
+ } else {
+ None
+ }
+
+ case (StructType(fields1), StructType(fields2)) =>
+ val fieldTypes = fields1.zip(fields2).map { case (f1, f2) =>
--- End diff --
this requires that fields with the same name must also be in the same
position. Is this assumption correct?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
