Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20010#discussion_r159575582
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -462,27 +507,139 @@ class TypeCoercionSuite extends AnalysisTest {
ArrayType(DoubleType, containsNull = false),
Some(ArrayType(DoubleType, containsNull = true)))
widenTestWithStringPromotion(
- ArrayType(TimestampType, containsNull = false),
- ArrayType(StringType, containsNull = true),
+ ArrayType(ArrayType(IntegerType), containsNull = true),
+ ArrayType(ArrayType(LongType), containsNull = false),
+ Some(ArrayType(ArrayType(LongType), containsNull = true)))
--- End diff --
Do we really wanna do this? Is there any other database have this behavior?
I think for complex type, we should ignore the nullable difference, but I'm
not sure if we should do type coercion inside complex type.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
