Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20267#discussion_r161417524
  
    --- Diff: dev/create-release/release-build.sh ---
    @@ -290,6 +290,8 @@ if [[ "$1" == "docs" ]]; then
       cd docs
       # TODO: Make configurable to add this: PRODUCTION=1
       PRODUCTION=1 RELEASE_VERSION="$SPARK_VERSION" jekyll build
    +  ret=$?
    +  if [[ $ret != 0 ]]; then exit $ret; fi
    --- End diff --
    
    Wait .. `set -e` is in effect. Just to be clear, `jekyll build` exits with 
non-zero code but `set -e` fails to catch it? I am fine as is if it fixes the 
issue anyway.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to