Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20267#discussion_r161444163
--- Diff: dev/create-release/release-build.sh ---
@@ -290,6 +290,8 @@ if [[ "$1" == "docs" ]]; then
cd docs
# TODO: Make configurable to add this: PRODUCTION=1
PRODUCTION=1 RELEASE_VERSION="$SPARK_VERSION" jekyll build
+ ret=$?
+ if [[ $ret != 0 ]]; then exit $ret; fi
--- End diff --
oh very excellent point. I tested in a script without `set -e`, and did see
`set -e` wondering a bit what it wasn't doing.
I guess more digging through the jekyll code.
I did find the `wait` for make_binary_release won't work through - it was
said to return exit code 0 if the `wait` was without process ID.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
