Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r161656419
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,67 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
object ImageSchema {
- val undefinedImageType = "Undefined"
+ /**
+ * OpenCv type representation
+ *
+ * @param mode ordinal for the type
+ * @param dataType open cv data type
--- End diff --
small nitpick: I think we should always spell it as "OpenCV" to be
consistent in the comments (unless you have any good objections)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
