Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20168#discussion_r161664060
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/image/ImageSchemaSuite.scala ---
    @@ -83,7 +83,8 @@ class ImageSchemaSuite extends SparkFunSuite with 
MLlibTestSparkContext {
             val bytes20 = getData(row).slice(0, 20)
     
             val (expectedMode, expectedBytes) = firstBytes20(filename)
    --- End diff --
    
    Since you use `ocvTypeByName` below to look up for it, it should be named 
as `expectedType` or `expectedTypeName`, other than `expectedMode`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to