Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20287#discussion_r161950447
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -65,10 +65,13 @@ private[ui] class AllJobsPage(parent: JobsTab, store:
AppStatusStore) extends We
}.map { job =>
val jobId = job.jobId
val status = job.status
- val jobDescription =
store.lastStageAttempt(job.stageIds.max).description
- val displayJobDescription = jobDescription
- .map(UIUtils.makeDescription(_, "", plainText = true).text)
- .getOrElse("")
+ var displayJobDescription = ""
+ try {
+ displayJobDescription =
store.lastStageAttempt(job.stageIds.max).description
+ .map(UIUtils.makeDescription(_, "", plainText =
true).text).getOrElse("")
+ } catch {
+ case e => displayJobDescription = job.description.getOrElse("")
--- End diff --
No, you're catching all exceptions. This should check whether the last
stage attempt exists rather than catching anything that goes wrong.
I don't think it's correct to pretend it exists but is empty. The request
is for something that doesn't exist and ideally generates a 404.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
