Github user smurakozi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20287#discussion_r162566562
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala ---
    @@ -335,9 +335,12 @@ private[ui] class JobPage(parent: JobsTab, store: 
AppStatusStore) extends WebUIP
     
         content ++= makeTimeline(activeStages ++ completedStages ++ 
failedStages,
           store.executorList(false), appStartTime)
    -
    -    content ++= UIUtils.showDagVizForJob(
    -      jobId, store.operationGraphForJob(jobId))
    +    try {
    +      content ++= UIUtils.showDagVizForJob(
    +        jobId, store.operationGraphForJob(jobId))
    +    } catch {
    +      case e => None
    +    }
    --- End diff --
    
    Same here. We should avoid the situation when the exception is thrown. 
Catching the exception and doing nothing just hides the problems.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to