Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/20169
  
    > but I don't think it's quite useful to leave cc to few specific 
committers as a requirement 
    
    I agree with that, we should not be bound to a few specific committers. But 
I think it's good and polite to **notify** people who is the major author of 
the file being touched, even he is not a committer. For example, the major 
author of the touched `HiveClientImpl.scala` is @gatorsmile .
    
    > I think it's basically committer's responsibility to check PRs, rather 
than asking PR authors to ping and wait for reviews to few specific committers.
    
    I also agree with that, I'm also happy to see this PR got reviewed and 
merged. My only concern is we should notify people who wrote the code you are 
changing, and we doesn't need to wait for the response.
     


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to