Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20373#discussion_r164343686
  
    --- Diff: python/pyspark/cloudpickle.py ---
    @@ -1019,18 +948,40 @@ def __reduce__(cls):
             return cls.__name__
     
     
    -def _fill_function(func, globals, defaults, dict, module, closure_values):
    -    """ Fills in the rest of function data into the skeleton function 
object
    -        that were created via _make_skel_func().
    +def _fill_function(*args):
    +    """Fills in the rest of function data into the skeleton function object
    +
    +    The skeleton itself is create by _make_skel_func().
    --- End diff --
    
    I don't think we made the guarantee on it but the best is always to stay 
safer. Others seem bug fixes but this one could be a regression (about the 
support we haven't guaranteed). It's the part of 0.4.2v anyway.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to