Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/20459#discussion_r165189663
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -93,7 +93,7 @@ private[feature] trait QuantileDiscretizerBase extends
Params
* @group param
*/
@Since("2.1.0")
- override val handleInvalid: Param[String] = new Param[String](this,
"handleInvalid",
+ final override val handleInvalid: Param[String] = new
Param[String](this, "handleInvalid",
--- End diff --
For this and the followings who added before 2.2, this involves breaking
change in a way, but I think we should keep them ```final``` to prevent being
changed(as we did for other param variables). cc @MLnick @WeichenXu123
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
