Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20459#discussion_r165229102
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -93,7 +93,7 @@ private[feature] trait QuantileDiscretizerBase extends
Params
* @group param
*/
@Since("2.1.0")
- override val handleInvalid: Param[String] = new Param[String](this,
"handleInvalid",
+ final override val handleInvalid: Param[String] = new
Param[String](this, "handleInvalid",
--- End diff --
I'm more prefer to mark them as non final, since if user want to extend
these estimators they would be able to override `handleInvalid` to define their
own `handleInvalid` valid values (through `doc` parameter of `Param` class
constructor) , this is different from other classes. What do you think of it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
