Github user vanzin commented on a diff in the pull request:
    --- Diff: 
core/src/main/scala/org/apache/spark/status/api/v1/ApiRootResource.scala ---
    @@ -83,6 +83,8 @@ private[spark] trait UIRoot {
       def getApplicationInfoList: Iterator[ApplicationInfo]
       def getApplicationInfo(appId: String): Option[ApplicationInfo]
    +  def executorThreadDumpsNotAvailableError(): Option[Response] = None
    --- End diff --
    This feels a little odd. You could instead have a `def threadDump(...): 
Response` method and have the implementation of it be in each `UIRoot` 
implementation, instead of in the resource class. I think I prefer that a 
little bit more over this.


To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to