Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20474#discussion_r165731119
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/api/v1/ApiRootResource.scala ---
    @@ -83,6 +83,8 @@ private[spark] trait UIRoot {
       def getApplicationInfoList: Iterator[ApplicationInfo]
       def getApplicationInfo(appId: String): Option[ApplicationInfo]
     
    +  def executorThreadDumpsNotAvailableError(): Option[Response] = None
    --- End diff --
    
    In fact, now that you pointed out the method to get the thread dump is in 
`SparkContext`, maybe you don't even need this at all. In the existing resource 
code, you can just return the error if `ui.sc` is not defined (e.g. "Thread 
dumps are only available in live applications.")


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to