Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2890#discussion_r19197345
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala ---
@@ -259,7 +264,7 @@ private[spark] class ExternalSorter[K, V, C](
private def spillToMergeableFile(collection:
SizeTrackingPairCollection[(Int, K), C]): Unit = {
assert(!bypassMergeSort)
- val (blockId, file) = diskBlockManager.createTempBlock()
+ val (blockId, file) = diskBlockManager.createTempShuffleBlock()
--- End diff --
Could you add a detailed comment here to explain that this needs to be a
temp shuffle block because the read side expects to read this back with
`spark.shuffle.compress` instead of `spark.shuffle.spill.compress`? I think
it's worth including the JIRA number in the comments too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
