Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2890#discussion_r19197366
--- Diff: core/src/test/scala/org/apache/spark/ShuffleSuite.scala ---
@@ -242,6 +242,28 @@ abstract class ShuffleSuite extends FunSuite with
Matchers with LocalSparkContex
assert(thrown.getClass === classOf[SparkException])
assert(thrown.getMessage.toLowerCase.contains("serializable"))
}
+
+ test("shuffle with shuffle.spill.compress=true, shuffle.compress=false
(SPARK-3426)") {
+ val conf = new SparkConf()
+ .setAppName("test")
+ .setMaster("local")
+ .set("spark.shuffle.spill.compress", "true")
+ .set("spark.shuffle.compress", "false")
+ .set("spark.shuffle.memoryFraction", "0.001")
+ sc = new SparkContext(conf)
+ sc.parallelize(0 until 100000).map(i => (i/4,
i)).groupByKey().collect()
+ }
+
+ test("shuffle with shuffle.spill.compress=false, shuffle.compress=true
(SPARK-3426)") {
+ val conf = new SparkConf()
+ .setAppName("test")
+ .setMaster("local")
+ .set("spark.shuffle.spill.compress", "false")
+ .set("spark.shuffle.compress", "true")
+ .set("spark.shuffle.memoryFraction", "0.001")
+ sc = new SparkContext(conf)
+ sc.parallelize(0 until 100000).map(i => (i/4,
i)).groupByKey().collect()
+ }
--- End diff --
Could we merge these into 1 test that tests all 4 combinations of the two
configs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
