Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20474#discussion_r166088682 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/OneApplicationResource.scala --- @@ -51,6 +51,52 @@ private[v1] class AbstractApplicationResource extends BaseAppResource { @Path("executors") def executorList(): Seq[ExecutorSummary] = withUI(_.store.executorList(true)) + @GET + @Path("executors/{executorId}/threads") + def threadDump(@PathParam("executorId") executorId: String): Response = withUI { ui => + val safeExecutorId = + Option(UIUtils.stripXSS(executorId)).map { executorId => + UIUtils.decodeURLParameter(executorId) + }.getOrElse { + throw new IllegalArgumentException(s"Missing executorId parameter") + } + + def isAllDigits(x: String) = x.forall(Character.isDigit) + + if (executorId != SparkContext.DRIVER_IDENTIFIER && !isAllDigits(executorId)) { + Response.serverError() --- End diff -- Throw `BadParameterException` instead.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org