Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20474#discussion_r166089402
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/api/v1/OneApplicationResource.scala 
---
    @@ -51,6 +51,52 @@ private[v1] class AbstractApplicationResource extends 
BaseAppResource {
       @Path("executors")
       def executorList(): Seq[ExecutorSummary] = 
withUI(_.store.executorList(true))
     
    +  @GET
    +  @Path("executors/{executorId}/threads")
    +  def threadDump(@PathParam("executorId") executorId: String): Response = 
withUI { ui =>
    --- End diff --
    
    If you throw exceptions in the code below instead, you can have a more 
specialized return type here, which I slightly prefer. 
    
    Not all errors currently have exceptions (e.g. 503 is missing), but it's 
easy to add them.
    
    (I also don't remember exactly what version of JAX-RS is being used by 
Spark, but if it's 2.1, that version has all these exceptions already, so some 
cleanup could be done here. 2.0 doesn't have them though.)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to