Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20554#discussion_r167123199
  
    --- Diff: 
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
 ---
    @@ -408,8 +401,27 @@ private[kafka010] object KafkaSourceProvider extends 
Logging {
       private[kafka010] val STARTING_OFFSETS_OPTION_KEY = "startingoffsets"
       private[kafka010] val ENDING_OFFSETS_OPTION_KEY = "endingoffsets"
       private val FAIL_ON_DATA_LOSS_OPTION_KEY = "failondataloss"
    +
       val TOPIC_OPTION_KEY = "topic"
     
    +  val INSTRUCTION_FOR_FAIL_ON_DATA_LOSS_FALSE =
    --- End diff --
    
    Moved this from KafkaSource to this class because this is used by multiple 
reader classes and therefore should be present in the higher level class (e.g. 
the provider class).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to