Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/20554#discussion_r167124564
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala
---
@@ -303,94 +302,75 @@ class KafkaMicroBatchSourceSuite extends
KafkaSourceSuiteBase {
)
}
- testWithUninterruptibleThread(
--- End diff --
I think this test is superfluous and does not test anything useful. As with
the other modified tests, "simulating" an implementation is a BAD test, and in
this particular case it is attempting to simulate the 2.1.0 log, which is not
necessary any more.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
