Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20511#discussion_r167937286
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
 ---
    @@ -160,6 +160,16 @@ abstract class OrcSuite extends OrcTest with 
BeforeAndAfterAll {
           }
         }
       }
    +
    +  // This is a test case for ORC-285
    --- End diff --
    
    This is the only issue for the new ORC reader, right? 
    
    For the other two ORC reading modes, it works well, right? Could you also 
added test cases for the others too?
    
    If this is the case, this should be a regression we have to merge to 2.3 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to