Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20511#discussion_r167942768
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
 ---
    @@ -160,6 +160,16 @@ abstract class OrcSuite extends OrcTest with 
BeforeAndAfterAll {
           }
         }
       }
    +
    +  // This is a test case for ORC-285
    --- End diff --
    
    Yes. This is only issue for the new ORC reader, but I added this test case 
here for both `OrcSourceSuite` and `HiveOrcSourceSuite` to make it sure.
    
    For Hive tables, if it needed, we had to create another test case. I'll try.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to