Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20555#discussion_r168066120
--- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java
---
@@ -230,6 +227,7 @@ private void signalAsyncReadComplete() {
private void waitForAsyncReadComplete() throws IOException {
stateChangeLock.lock();
+ isWaiting.set(true);
try {
while (readInProgress) {
--- End diff --
shall we add a comment about spurious wakeup? Otherwise someone else may
still mistakenly remove it in the future.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
