Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20546#discussion_r168144704
  
    --- Diff: core/src/main/java/org/apache/spark/SparkExecutorInfo.java ---
    @@ -30,4 +30,8 @@
       int port();
       long cacheSize();
       int numRunningTasks();
    +  long usedOnHeapStorageMemory();
    --- End diff --
    
    I'm not disagreeing with you on making such changes, but I'm also worrying 
about users could have to change their code a lot because of the changes we 
made. If you don't mind, may I submit a follow up PR to minimize the gap 
between the `SparkExecutorInfo` and `StorageStatus`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to