Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20556#discussion_r168263151
  
    --- Diff: dev/lint-python ---
    @@ -82,6 +87,34 @@ else
         rm "$PYCODESTYLE_REPORT_PATH"
     fi
     
    +# Check python document style, skip check if pydocstyle is not installed.
    +if hash "$PYDOCSTYLEBUILD" 2> /dev/null; then
    +    if [ $PYDOCSTYLEVERSION == "2.1.1" ]; then
    +        pydocstyle --config=dev/tox.ini $DOC_PATHS_TO_CHECK >> 
"$PYDOCSTYLE_REPORT_PATH"
    +        pydocstyle_status="${PIPESTATUS[0]}"
    +
    +        if [ "$compile_status" -eq 0 -a "$pydocstyle_status" -eq 0 ]; then
    +            lint_status=0
    +        else
    +            lint_status=1
    +        fi
    +
    +        if [ "$lint_status" -ne 0 ]; then
    --- End diff --
    
    could you just move this block above and get rid of `lint_status`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to