Github user misutoth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20618#discussion_r168578156
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -1313,131 +1313,178 @@ object functions {
       
//////////////////////////////////////////////////////////////////////////////////////////////
     
       /**
    -   * Computes the cosine inverse of the given value; the returned angle is 
in the range
    -   * 0.0 through pi.
    +   * @param e the value whose arc cosine is to be returned
    +   * @return  cosine inverse of the given value in the range of 0.0 
through pi,
    --- End diff --
    
    I am not sure what you mean on _above_. Do you mean reverting this part of 
the change?
    
    How about simply `@return the angle whose cosine is 'e'` and refer to 
java.lang.Math for further details?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to