Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20627#discussion_r169116845
  
    --- Diff: python/pyspark/ml/evaluation.py ---
    @@ -394,15 +397,30 @@ def getMetricName(self):
         @keyword_only
         @since("2.3.0")
         def setParams(self, predictionCol="prediction", featuresCol="features",
    -                  metricName="silhouette"):
    +                  metricName="silhouette", 
distanceMeasure="squaredEuclidean"):
    --- End diff --
    
    I am not expert enough in Python to answer this. A normal python script is 
interpreted at runtime, so source code compatibility should be enough, but a 
`.pyc` file might have the same issue in theory.
    I'd love to hear the answer from someone with more experience on Python.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to