Github user BryanCutler commented on a diff in the pull request:
    --- Diff: python/pyspark/ml/ ---
    @@ -394,15 +397,30 @@ def getMetricName(self):
         def setParams(self, predictionCol="prediction", featuresCol="features",
    -                  metricName="silhouette"):
    +                  metricName="silhouette", 
    --- End diff --
    Yeah these will not cause any incompatibility issues, the interpreter would 
automatically just pass the additional keyword arg.  These methods are actually 
all wrapped with `keyword_only` which make it look externally like 
`setParams(**kwargs)`, anyway.


To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to