Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20043#discussion_r169223825
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
 ---
    @@ -75,7 +75,7 @@ case class BoundReference(ordinal: Int, dataType: 
DataType, nullable: Boolean)
                  |$javaType ${ev.value} = ${ev.isNull} ? 
${ctx.defaultValue(dataType)} : ($value);
                """.stripMargin)
           } else {
    -        ev.copy(code = s"$javaType ${ev.value} = $value;", isNull = 
"false")
    +        ev.copy(code = s"$javaType ${ev.value} = $value;", isNull = 
LiteralValue("false"))
    --- End diff --
    
    I think it should be useful to the `isNull` field.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to