Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20043#discussion_r171262081
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -323,7 +323,8 @@ class CodegenContext {
case _: StructType | _: ArrayType | _: MapType => s"$value =
$initCode.copy();"
case _ => s"$value = $initCode;"
}
- ExprCode(code, "false", value)
+ ExprCode(code, FalseLiteral,
+ GlobalValue(value, ExprType(this, dataType)))
--- End diff --
nit: this can go on one line
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
