Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20057#discussion_r169688539
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/jdbc/TeradataDialect.scala ---
    @@ -31,4 +31,19 @@ private case object TeradataDialect extends JdbcDialect {
         case BooleanType => Option(JdbcType("CHAR(1)", java.sql.Types.CHAR))
         case _ => None
       }
    +
    +  override def isCascadingTruncateTable(): Option[Boolean] = Some(false)
    +
    +  /**
    +   * The SQL query used to truncate a table.
    --- End diff --
    
    Please add more description about Teradata's lack of `TRUNCATE` syntax 
here. Otherwise, people try to make a PR for this mistakenly.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to