Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r169692604
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -839,35 +839,68 @@ class JDBCSuite extends SparkFunSuite
}
test("table exists query by jdbc dialect") {
- val MySQL = JdbcDialects.get("jdbc:mysql://127.0.0.1/db")
- val Postgres = JdbcDialects.get("jdbc:postgresql://127.0.0.1/db")
+ val mysql = JdbcDialects.get("jdbc:mysql://127.0.0.1/db")
+ val postgres = JdbcDialects.get("jdbc:postgresql://127.0.0.1/db")
val db2 = JdbcDialects.get("jdbc:db2://127.0.0.1/db")
val h2 = JdbcDialects.get(url)
val derby = JdbcDialects.get("jdbc:derby:db")
val table = "weblogs"
val defaultQuery = s"SELECT * FROM $table WHERE 1=0"
val limitQuery = s"SELECT 1 FROM $table LIMIT 1"
- assert(MySQL.getTableExistsQuery(table) == limitQuery)
- assert(Postgres.getTableExistsQuery(table) == limitQuery)
+ assert(mysql.getTableExistsQuery(table) == limitQuery)
+ assert(postgres.getTableExistsQuery(table) == limitQuery)
assert(db2.getTableExistsQuery(table) == defaultQuery)
assert(h2.getTableExistsQuery(table) == defaultQuery)
assert(derby.getTableExistsQuery(table) == defaultQuery)
}
test("truncate table query by jdbc dialect") {
--- End diff --
For this test case, we added `oracle` and `teradata`. It's okay to update
this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
