Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/20632#discussion_r169834234
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -362,10 +365,10 @@ class RandomForestSuite extends SparkFunSuite with
MLlibTestSparkContext {
assert(topNode.isLeaf === false)
assert(topNode.stats === null)
- val nodesForGroup = Map((0, Array(topNode)))
- val treeToNodeToIndexInfo = Map((0, Map(
- (topNode.id, new RandomForest.NodeIndexInfo(0, None))
- )))
+ val nodesForGroup = Map(0 -> Array(topNode))
--- End diff --
These are fine, but I slightly prefer leaving stuff like this out. These
aren't strictly style violations, and it distracts reviewers from the actual
changes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
