Github user asolimando commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20632#discussion_r170140738
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
    @@ -362,10 +365,10 @@ class RandomForestSuite extends SparkFunSuite with 
MLlibTestSparkContext {
         assert(topNode.isLeaf === false)
         assert(topNode.stats === null)
     
    -    val nodesForGroup = Map((0, Array(topNode)))
    -    val treeToNodeToIndexInfo = Map((0, Map(
    -      (topNode.id, new RandomForest.NodeIndexInfo(0, None))
    -    )))
    +    val nodesForGroup = Map(0 -> Array(topNode))
    --- End diff --
    
    Two tests previously moved here have now been moved back, there is still
    _"Use soft prediction for binary classification with ordered categorical 
features"_ to which I have applied @srowen 's comment, so the consistency 
argument still holds (even if weakened a bit).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to