Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19788#discussion_r169899114
  
    --- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
    @@ -295,8 +307,8 @@ private[spark] abstract class MapOutputTracker(conf: 
SparkConf) extends Logging
        *         and the second item is a sequence of (shuffle block id, 
shuffle block size) tuples
        *         describing the shuffle blocks that are stored at that block 
manager.
        */
    -  def getMapSizesByExecutorId(shuffleId: Int, startPartition: Int, 
endPartition: Int)
    -      : Seq[(BlockManagerId, Seq[(BlockId, Long)])]
    +  def getMapSizesByExecutorId(shuffleId: Int, startPartition: Int, 
endPartition: Int,
    +      serializer: Serializer = null): Seq[(BlockManagerId, Seq[(BlockId, 
Long)])]
    --- End diff --
    
    if possible let's not introduce a default value here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to