Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19222#discussion_r171784371
  
    --- Diff: 
common/unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSetMethods.java 
---
    @@ -45,6 +46,14 @@ public static void set(Object baseObject, long 
baseOffset, int index) {
         Platform.putLong(baseObject, wordOffset, word | mask);
       }
     
    +  public static void setBlock(MemoryBlock base, long baseOffset, int 
index) {
    --- End diff --
    
    It is better to add doc for it. It is not clear to know what purpose of 
this method.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to