Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19222#discussion_r171787508
  
    --- Diff: 
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -50,12 +52,12 @@
     
       // These are only updated by readExternal() or read()
       @Nonnull
    -  private Object base;
    -  private long offset;
    +  private MemoryBlock base;
    +  // While numBytes has the same value as base,length, to keep as int 
avoids cast from long to int
    --- End diff --
    
    nit: `base,length` -> `base, length`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to